Okay, so by ignition switch I mean start button.

The kill switch and start button were connected as in the above diagram when I got the quad, but as mentioned above, that setup didn't make sense to me. So the orange and pink/green is now currently connected to the start button, with the black/white and green connected to the kill switch (I missed that green off the diagram and the green off the ignition barrel).

This is the setup as I currently have it (hopefully I haven't missed anything this time):



Thanks again

 

Everything looks correct. You need a brake on for the start button to work but that is normal. Not quite sure what your problem now is, if there is still no spark when engine is spun on starter, check the kill wire black/white at the CDI plug, it should be negative with key switch one way and open circuit with key switch the other. Usually open circuit with ignition on, but some makes do it t'other way round, so key switch and CDI need to be compatible.